race condition fixed, payment inside

This commit is contained in:
root
2025-12-21 09:56:59 +01:00
parent 6741f5ed72
commit 67646c75a4
6 changed files with 714 additions and 30 deletions

View File

@@ -0,0 +1,81 @@
import { NextRequest, NextResponse } from 'next/server'
import { cookies } from 'next/headers'
import pool from '@/lib/db'
// DELETE /api/payments/cancel-pending - Cancel a pending order (frees up inventory)
export async function DELETE(request: NextRequest) {
try {
// Get buyer_id from session cookie
const cookieStore = await cookies()
const buyerIdCookie = cookieStore.get('buyer_id')?.value
if (!buyerIdCookie) {
return NextResponse.json(
{ error: 'Authentication required' },
{ status: 401 }
)
}
const buyer_id = parseInt(buyerIdCookie, 10)
const body = await request.json()
const { payment_id } = body
// Validate required fields
if (!payment_id) {
return NextResponse.json(
{ error: 'Missing required field: payment_id' },
{ status: 400 }
)
}
// Find the pending order
const [pendingRows] = await pool.execute(
'SELECT * FROM pending_orders WHERE payment_id = ? AND buyer_id = ?',
[payment_id, buyer_id]
)
const pendingOrders = pendingRows as any[]
if (pendingOrders.length === 0) {
return NextResponse.json(
{ error: 'Pending order not found or already cancelled' },
{ status: 404 }
)
}
const pendingOrder = pendingOrders[0]
// Check if payment has already been confirmed (sale exists)
const [salesRows] = await pool.execute(
'SELECT * FROM sales WHERE payment_id = ?',
[payment_id]
)
const sales = salesRows as any[]
if (sales.length > 0) {
// Payment already confirmed, don't delete pending order
// The IPN handler should have already deleted it, but if not, leave it
return NextResponse.json(
{ error: 'Payment already confirmed. Cannot cancel.' },
{ status: 400 }
)
}
// Delete the pending order (frees up inventory)
await pool.execute(
'DELETE FROM pending_orders WHERE payment_id = ? AND buyer_id = ?',
[payment_id, buyer_id]
)
return NextResponse.json({
message: 'Pending order cancelled successfully',
payment_id: payment_id,
})
} catch (error) {
console.error('Error cancelling pending order:', error)
return NextResponse.json(
{ error: 'Failed to cancel pending order' },
{ status: 500 }
)
}
}

View File

@@ -43,11 +43,31 @@ export async function GET(request: NextRequest) {
const pendingOrders = pendingRows as any[]
const sales = salesRows as any[]
if (pendingOrders.length === 0 && sales.length === 0) {
return NextResponse.json(
{ error: 'Payment not found' },
{ status: 404 }
)
// Check if pending order exists and if sale exists
const hasPendingOrder = pendingOrders.length > 0
const hasSale = sales.length > 0
// If pending order is gone and sale exists, payment was processed
if (!hasPendingOrder && hasSale) {
return NextResponse.json({
payment_id,
status: 'completed',
payment_status: 'completed',
has_pending_order: false,
has_sale: true,
sale: sales[0],
})
}
// If both are gone, payment was cancelled or expired
if (!hasPendingOrder && !hasSale) {
return NextResponse.json({
payment_id,
status: 'cancelled',
payment_status: 'cancelled',
has_pending_order: false,
has_sale: false,
})
}
// Get NOWPayments config (testnet or production)
@@ -82,6 +102,8 @@ export async function GET(request: NextRequest) {
pay_currency: paymentStatus.pay_currency,
price_amount: paymentStatus.price_amount,
price_currency: paymentStatus.price_currency,
has_pending_order: hasPendingOrder,
has_sale: hasSale,
})
} catch (error) {
console.error('Error checking payment status:', error)

View File

@@ -3,7 +3,9 @@ import { cookies } from 'next/headers'
import pool from '@/lib/db'
import { getNowPaymentsConfig } from '@/lib/nowpayments'
// POST /api/payments/create-invoice - Create a NOWPayments invoice
// POST /api/payments/create-invoice - Create a NOWPayments payment
// Note: Endpoint name kept as "create-invoice" for backward compatibility
// but it now uses the /v1/payment endpoint instead of /v1/invoice
export async function POST(request: NextRequest) {
try {
// Get buyer_id from session cookie
@@ -20,7 +22,7 @@ export async function POST(request: NextRequest) {
const buyer_id = parseInt(buyerIdCookie, 10)
const body = await request.json()
const { drop_id, size } = body
const { drop_id, size, pay_currency } = body
// Validate required fields
if (!drop_id || !size) {
@@ -132,10 +134,16 @@ export async function POST(request: NextRequest) {
const expiresAt = new Date()
expiresAt.setMinutes(expiresAt.getMinutes() + 10)
// Create NOWPayments invoice
// Note: NOWPayments doesn't support invoice_timeout parameter
// Expiration is handled by our pending_orders table (10 minutes)
const nowPaymentsResponse = await fetch(`${nowPaymentsConfig.baseUrl}/v1/invoice`, {
// Create NOWPayments payment
// Note: Payment API requires pay_currency (crypto currency)
// Use currency from request, or fall back to env/default
const payCurrency = pay_currency || process.env.NOWPAYMENTS_PAY_CURRENCY || 'btc'
// Optional: Use fixed rate for 20 minutes (prevents rate changes during checkout)
// If is_fixed_rate is true, payment expires after 20 minutes if not paid
const isFixedRate = process.env.NOWPAYMENTS_FIXED_RATE === 'true' || false
const nowPaymentsResponse = await fetch(`${nowPaymentsConfig.baseUrl}/v1/payment`, {
method: 'POST',
headers: {
'x-api-key': nowPaymentsConfig.apiKey,
@@ -144,11 +152,11 @@ export async function POST(request: NextRequest) {
body: JSON.stringify({
price_amount: priceAmount,
price_currency: nowPaymentsConfig.currency,
pay_currency: payCurrency, // Required: crypto currency (btc, eth, etc)
order_id: orderId,
order_description: `${drop.item} - ${size}g`,
ipn_callback_url: ipnCallbackUrl,
success_url: `${baseUrl}/?payment=success&order_id=${orderId}`,
cancel_url: `${baseUrl}/?payment=cancelled&order_id=${orderId}`,
is_fixed_rate: isFixedRate, // Optional: freeze exchange rate for 20 minutes
}),
})
@@ -158,28 +166,36 @@ export async function POST(request: NextRequest) {
await connection.rollback()
connection.release()
return NextResponse.json(
{ error: 'Failed to create payment invoice', details: error },
{ error: 'Failed to create payment', details: error },
{ status: 500 }
)
}
const invoice = await nowPaymentsResponse.json()
const payment = await nowPaymentsResponse.json()
// Store pending order with expiration time (atomically reserves inventory)
// payment.payment_id is the NOWPayments payment ID
await connection.execute(
'INSERT INTO pending_orders (payment_id, order_id, drop_id, buyer_id, size, price_amount, price_currency, expires_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)',
[invoice.id, orderId, drop_id, buyer_id, size, priceAmount, nowPaymentsConfig.currency, expiresAt]
[payment.payment_id, orderId, drop_id, buyer_id, size, priceAmount, nowPaymentsConfig.currency, expiresAt]
)
// Commit transaction - inventory is now reserved
await connection.commit()
connection.release()
// Return invoice URL - sale will be created by external IPN handler when payment is confirmed
// Return payment details - sale will be created by external IPN handler when payment is confirmed
return NextResponse.json({
invoice_url: invoice.invoice_url,
payment_id: invoice.id,
payment_id: payment.payment_id,
payment_status: payment.payment_status,
pay_address: payment.pay_address, // Address where customer sends payment
pay_amount: payment.pay_amount, // Amount in crypto to pay
pay_currency: payment.pay_currency, // Crypto currency
price_amount: payment.price_amount, // Price in fiat
price_currency: payment.price_currency, // Fiat currency
order_id: orderId,
payin_extra_id: payment.payin_extra_id, // Memo/tag for certain currencies (XRP, XLM, etc)
expiration_estimate_date: payment.expiration_estimate_date, // When payment expires
}, { status: 201 })
} catch (error) {
await connection.rollback()
@@ -187,9 +203,9 @@ export async function POST(request: NextRequest) {
throw error
}
} catch (error) {
console.error('Error creating invoice:', error)
console.error('Error creating payment:', error)
return NextResponse.json(
{ error: 'Failed to create invoice' },
{ error: 'Failed to create payment' },
{ status: 500 }
)
}

View File

@@ -0,0 +1,43 @@
import { NextResponse } from 'next/server'
import { getNowPaymentsConfig } from '@/lib/nowpayments'
// GET /api/payments/currencies - Get available payment currencies from NOWPayments
export async function GET() {
try {
const nowPaymentsConfig = getNowPaymentsConfig()
// Fetch available currencies from NOWPayments
const response = await fetch(
`${nowPaymentsConfig.baseUrl}/v1/currencies?fixed_rate=true`,
{
method: 'GET',
headers: {
'x-api-key': nowPaymentsConfig.apiKey,
},
}
)
if (!response.ok) {
const error = await response.json()
console.error('NOWPayments currencies error:', error)
return NextResponse.json(
{ error: 'Failed to fetch available currencies', details: error },
{ status: 500 }
)
}
const data = await response.json()
// Return the currencies array
return NextResponse.json({
currencies: data.currencies || [],
})
} catch (error) {
console.error('Error fetching currencies:', error)
return NextResponse.json(
{ error: 'Failed to fetch currencies' },
{ status: 500 }
)
}
}